-
Notifications
You must be signed in to change notification settings - Fork 420
refactor(parser): Improve error message when parsing models and envelopes #3587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(parser): Improve error message when parsing models and envelopes #3587
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3587 +/- ##
========================================
Coverage 95.78% 95.78%
========================================
Files 210 210
Lines 9683 9683
Branches 1774 1774
========================================
Hits 9275 9275
Misses 294 294
Partials 114 114 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some NP, otherwise good to go!
|
Issue number: #3580
Summary
Changes
This pull request enhances the error messaging in response to an AttributeError when parsing Models and Envelopes. The improved error message now provides more explicit details, making it easier to identify and address the root cause of the issue.
Before
[ERROR] InvalidEnvelopeError: Envelope must implement BaseEnvelope, envelope=<class 'aws_lambda_powertools.utilities.parser.envelopes.kinesis.KinesisDataStreamEnvelope'>
After
[ERROR] InvalidEnvelopeError: Error: 'list' object has no attribute 'test'. Please ensure that both the Input model and Envelope inherit from BaseModel,
And your payload adheres to the specified Input model structure.
Envelope=<class 'aws_lambda_powertools.utilities.parser.envelopes.kinesis.KinesisDataStreamEnvelope'>
Model=<class 'app.SuggestionPayload'>
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.