-
Notifications
You must be signed in to change notification settings - Fork 421
refactor(parameters): add overload signatures for get_parameter and get_parameters #3534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(parameters): add overload signatures for get_parameter and get_parameters #3534
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Looking at this now |
2a93569
to
30cb60f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!!! Only one missing... Literal["auto"]
. It uses the parameter suffix to find the transformation method to use (.binary
-> Binary, or .json
-> JSON).
Example in get_parameters_by_name
.
d5d099c
to
f5cfcc2
Compare
I've added the missing case. @heitorlessa please review when possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3534 +/- ##
========================================
Coverage 95.78% 95.78%
========================================
Files 210 210
Lines 9681 9681
Branches 1773 1773
========================================
Hits 9273 9273
Misses 294 294
Partials 114 114 ☔ View full report in Codecov by Sentry. |
59f71b1
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #3507
Summary
Changes
Adds overload signatures for the
get_parameter
andget_parameters
functions depending on the arguments present. Also defines the literals that are available in thetransform
argument.User experience
Type checkers should return the expected type based on the value in the
transform
argument.None
, return type should bestr
"json"
, return type should bedict
"binary"
, return type should bebytes
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
NoAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.