-
Notifications
You must be signed in to change notification settings - Fork 420
fix(event_handler): allow responses and metadata when using Router #3514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3514 +/- ##
========================================
Coverage 95.78% 95.78%
========================================
Files 209 210 +1
Lines 9675 9681 +6
Branches 1774 1774
========================================
+ Hits 9267 9273 +6
Misses 294 294
Partials 114 114 ☔ View full report in Codecov by Sentry. |
looking... 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a note to refactor that tuple into a class for better encapsulation and growth
|
Issue number: #3506
Summary
Changes
Some of the new additions related to OpenAPI support added non-hashable elements to the route key when using the built-in Router.
This made the code crash. With this change, we convert all those new parameters into hashable equivalents.
User experience
The following code now works:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
**RFC issue number**:Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.