Skip to content

fix(docs): make the Lambda Layer version consistent #3498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

rubenfonseca
Copy link
Contributor

Issue number: #3494

Summary

Changes

Please provide a summary of what's being changed

This PR fixes the inconsistent in the Lambda Layer version in our documentation. Now the layer version should be 54 in all supported regions.

We also updated the layer balancer code to support the most recent versions of Go.

User experience

Please share what the user experience looks like before and after this change

After this PR, customers can again use the same Lambda Layer version number across regions.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca rubenfonseca requested a review from a team December 13, 2023 14:04
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Dec 13, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 13, 2023
@rubenfonseca rubenfonseca linked an issue Dec 13, 2023 that may be closed by this pull request
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rubenfonseca!

1 - Should we balance the arm64 layer as well?
image

2 - Do you think is it possible to fix the description for new layers v54 in x86_64?

Thanks!

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2023
@rubenfonseca
Copy link
Contributor Author

@leandrodamascena fixed everything, ready to look again

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a last comment and it's good! Thanksss Ruben!!

rubenfonseca and others added 2 commits December 13, 2023 16:28
Co-authored-by: Leandro Damascena <[email protected]>
Signed-off-by: Ruben Fonseca <[email protected]>
Co-authored-by: Leandro Damascena <[email protected]>
Signed-off-by: Ruben Fonseca <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

@leandrodamascena leandrodamascena merged commit 6cd8ccd into develop Dec 13, 2023
@leandrodamascena leandrodamascena deleted the rf/fix-layer-version branch December 13, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Layer version is currently inconsistent
2 participants