-
Notifications
You must be signed in to change notification settings - Fork 420
fix(logger): log non-ascii characters as is when JSON stringifying #3475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logger): log non-ascii characters as is when JSON stringifying #3475
Conversation
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3475 +/- ##
========================================
Coverage 95.43% 95.43%
========================================
Files 209 209
Lines 9675 9675
Branches 1774 1774
========================================
Hits 9233 9233
Misses 329 329
Partials 113 113 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue number: #3474
Summary
This PR ensures default
json.dumps
used by Logger prints non-ascii values as-is instead of escaping them.Changes
User experience
Output
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.