-
Notifications
You must be signed in to change notification settings - Fork 420
fix(event_handler): serialize pydantic/dataclasses in exception handler #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(event_handler): serialize pydantic/dataclasses in exception handler #3455
Conversation
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3455 +/- ##
========================================
Coverage 95.41% 95.42%
========================================
Files 209 209
Lines 9648 9664 +16
Branches 1770 1773 +3
========================================
+ Hits 9206 9222 +16
Misses 329 329
Partials 113 113 ☔ View full report in Codecov by Sentry. |
Issue number: #3451
Summary
This PR changes Powertools JSON Encoder to always serialize pydantic v1/v2 and dataclasses. This addresses an issue for the new data validation feature in Event Handler, where customers might return a Pydantic model as a response in the exception handler.
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.