-
Notifications
You must be signed in to change notification settings - Fork 420
feat(event_sources): add get_context() to standardize API Gateway Lambda Authorizer context in v1 and v2 #3454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_sources): add get_context() to standardize API Gateway Lambda Authorizer context in v1 and v2 #3454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! minor changes to improve the end customer experience by having good defaults.
aws_lambda_powertools/utilities/data_classes/api_gateway_proxy_event.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/data_classes/api_gateway_proxy_event.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/data_classes/api_gateway_proxy_event.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/data_classes/api_gateway_proxy_event.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/data_classes/api_gateway_proxy_event.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3454 +/- ##
===========================================
- Coverage 95.42% 95.40% -0.02%
===========================================
Files 209 209
Lines 9664 9668 +4
Branches 1773 812 -961
===========================================
+ Hits 9222 9224 +2
- Misses 329 330 +1
- Partials 113 114 +1 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
Issue number: #3453
Other issue: #3444
Summary
Changes
We were using the wrong payload for v2 and assuming that this Payload contained a key called
lambda
. We updated the payload according to AWS Documentation.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.