-
Notifications
You must be signed in to change notification settings - Fork 420
fix(event_handler): allow fine grained Response with data validation #3394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3394 +/- ##
========================================
Coverage 95.39% 95.39%
========================================
Files 208 208
Lines 9638 9645 +7
Branches 1766 1767 +1
========================================
+ Hits 9194 9201 +7
Misses 330 330
Partials 114 114 ☔ View full report in Codecov by Sentry. |
fd122b5
to
9cbe227
Compare
tests/functional/event_handler/test_openapi_validation_middleware.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split tests; all great otherwise!
Kudos, SonarCloud Quality Gate passed!
|
Issue number: #3393
Summary
Changes
This PR adds support for returning Response objects when using data validation.
User experience
This is what it looks like:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.