Skip to content

fix(event_handler): allow fine grained Response with data validation #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Nov 22, 2023

Issue number: #3393

Summary

Changes

Please provide a summary of what's being changed

This PR adds support for returning Response objects when using data validation.

User experience

Please share what the user experience looks like before and after this change

This is what it looks like:

class User(BaseModel):
    name: str
    age: int

@app.post("/")
def handler(user: User) -> Response[User]:
    return Response(body=user, status_code=200)

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ce3ed1) 95.39% compared to head (eff77c8) 95.39%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3394   +/-   ##
========================================
  Coverage    95.39%   95.39%           
========================================
  Files          208      208           
  Lines         9638     9645    +7     
  Branches      1766     1767    +1     
========================================
+ Hits          9194     9201    +7     
  Misses         330      330           
  Partials       114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubenfonseca rubenfonseca marked this pull request as ready for review November 22, 2023 14:16
@rubenfonseca rubenfonseca requested review from a team and heitorlessa November 22, 2023 14:16
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split tests; all great otherwise!

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@heitorlessa heitorlessa changed the title fix(event_handler): allow use of Response with data validation fix(event_handler): allow fine grained Response with data validation Nov 22, 2023
@heitorlessa heitorlessa merged commit 270060d into develop Nov 22, 2023
@heitorlessa heitorlessa deleted the rf/generic_response branch November 22, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event_handlers size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Data validation doesn't support the return of Response objects
3 participants