fix(event_handler): apply serialization as the last operation for middlewares #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
rubenfonseca
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3392 +/- ##
========================================
Coverage 95.39% 95.39%
========================================
Files 208 208
Lines 9637 9638 +1
Branches 1766 1766
========================================
+ Hits 9193 9194 +1
Misses 330 330
Partials 114 114 ☔ View full report in Codecov by Sentry. |
heitorlessa
changed the title
heitorlessa
reviewed
Nov 22, 2023
pull-request-size
bot
added
size/M
heitorlessa
suggested changes
Nov 22, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
heitorlessa
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #3391
Summary
Changes
This PR moves the serialization on event handler to the very last step before returning to the client. This allows all middlewares to see the original returns from the handler.
The serialization is also only applied if the content type of the response is JSON. This means we don't try to apply the serialization to HTML or PLAIN responses.
User experience
After this PR, a user can again use a custom serializer, even when using data validation.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.