Skip to content

docs(event-handler): fixed SchemaValidationMiddleware link #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jvnsg
Copy link
Contributor

@jvnsg jvnsg commented Oct 24, 2023

Issue number: #3246

Summary

Changes

Update link to 'SchemaValidationMiddleware'.

User experience

before: user gets redirected to error page
after: user gets redirected to 'SchemaValidationMiddleware' documentation

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@jvnsg jvnsg requested a review from a team October 24, 2023 16:09
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 24, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 24, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@leandrodamascena leandrodamascena changed the title Change link for 'SchemaValidationMiddleware' docs(event-handler): fix SchemaValidationMiddleware link Oct 24, 2023
@github-actions
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge need-issue PRs that are missing related issues labels Oct 24, 2023
@leandrodamascena leandrodamascena added event_handlers and removed do-not-merge need-issue PRs that are missing related issues labels Oct 24, 2023
@leandrodamascena leandrodamascena linked an issue Oct 24, 2023 that may be closed by this pull request
1 task
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this PR at lightning speed @jvnsg!

Approved.

@leandrodamascena leandrodamascena changed the title docs(event-handler): fix SchemaValidationMiddleware link docs(event-handler): fixed SchemaValidationMiddleware link Oct 24, 2023
@leandrodamascena leandrodamascena merged commit e37a6aa into aws-powertools:develop Oct 24, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 24, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation event_handlers size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Native middleware 'SchemaValidationMiddleware' has invalid link
2 participants