-
Notifications
You must be signed in to change notification settings - Fork 421
refactor(batch): type response() method #3023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(batch): type response() method #3023
Conversation
…ess_partial_response
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #3023 +/- ##
========================================
Coverage 96.56% 96.56%
========================================
Files 175 175
Lines 7825 7825
Branches 1476 1476
========================================
Hits 7556 7556
Misses 217 217
Partials 52 52
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were so fast @adriantomas! Thanks a lot for this PR and your first contribution.
LGTM
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #3020
Summary
Changes
PartialItemFailureReponse
as the typing returned byresponse()
ofBasePartialBatchProcessor
User experience
Users using
process_partial_response()
andresponse()
fromBasePartialBatchProcessor
will find that the returned response is the same.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.