Skip to content

fix(ci): change SAR assume role options #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

rubenfonseca
Copy link
Contributor

Issue number: #3004

Summary

Changes

Please provide a summary of what's being changed

This PR changes the options to assume the SAR role, due to breaking changes caused by a new major version of the action.

User experience

Please share what the user experience looks like before and after this change

The SAR application should be able to deploy when we release a new version of Powertools.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca rubenfonseca requested a review from a team August 25, 2023 14:37
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Aug 25, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot added the bug Something isn't working label Aug 25, 2023
@leandrodamascena leandrodamascena merged commit d437bf5 into develop Aug 25, 2023
@leandrodamascena leandrodamascena deleted the rf/fix-sar branch August 25, 2023 14:38
rubenfonseca added a commit that referenced this pull request Aug 25, 2023
rubenfonseca added a commit that referenced this pull request Aug 25, 2023
* Revert "fix(ci): change SAR assume role options (#3005)"

This reverts commit d437bf5.

* Revert "chore(deps): bump aws-actions/configure-aws-credentials from 2.2.0 to 3.0.0 (#3000)"

This reverts commit f0088bd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github-actions Pull requests that update Github_actions code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants