fix(metrics): preserve default_tags when metric-specific tag is set in Datadog provider #2997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2990
Summary
Changes
In this PR, we address an issue where
default_tags
were not preserved when adding metric-specific tags in the Datadog. We've implemented a fix to ensure that default_tags will be merged with metric-specific tags. We also fixed the precedence problem when default tags and metric-specific tags shared the same key, and now the metric-specific tags took precedence.I also added datadog-lambda dependency as optional. We mistakenly removed this in some reviews of the original PR.
User experience
CODE
Output before this fix:
Output after this fix:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.