feat: toggle to disable log deduplication locally for pytest live log #262 #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: heitorlessa <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #268 +/- ##
========================================
Coverage 99.75% 99.75%
========================================
Files 79 79
Lines 2820 2823 +3
Branches 115 116 +1
========================================
+ Hits 2813 2816 +3
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
This was referenced Jan 17, 2021
nmoutschen
approved these changes
Jan 18, 2021
| @@ -129,12 +129,14 @@ def __init__( | |||
| self.sampling_rate = resolve_env_var_choice( | |||
| choice=sampling_rate, env=os.getenv(constants.LOGGER_LOG_SAMPLING_RATE, 0.0) | |||
| ) | |||
| self._is_deduplication_disabled = resolve_truthy_env_var_choice( | |||
There was a problem hiding this comment.
NIT: We store whether the deduplication is disabled rather than enabled, then (line 175) we check against this flag not being true. It makes this flag a bit hard to read IMHO. Should we invert this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #262
Description of changes:
This allows customers to disable log deduplication filter protection to use Pytest Live Log feature (and similar). When root logger is configured, Powertools Logger will intercept any propagated message to prevent duplicates. This feature overrides this protection.
Pytest Live Log feature with this feature
Pytest Live Log feature without the explicit override
Docs
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.