-
Notifications
You must be signed in to change notification settings - Fork 421
feat(event_handler): add VPCLatticeResolver #2601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_handler): add VPCLatticeResolver #2601
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2601 +/- ##
===========================================
- Coverage 97.22% 97.16% -0.06%
===========================================
Files 160 161 +1
Lines 7394 7416 +22
Branches 537 525 -12
===========================================
+ Hits 7189 7206 +17
- Misses 158 161 +3
- Partials 47 49 +2
☔ View full report in Codecov by Sentry. |
Looking at this now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @leandrodamascena ! Super nice work!
It would be nice to have some E2E tests for this, but as I understand correctly, it's still hard to get this on CDK, right?
Yes Rubens! We need to create a VPC + VPC Lattice Network + Listener + Association + A Lambda inside this VPC and we can't invoke the VPC Lattice endpoint outside the vpc because it's not a public endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, thank you @leandrodamascena !
Issue number: #2577
Summary
Changes
Amazon VPC Lattice is a fully managed application networking service that you use to connect, secure, and monitor the services for your application across multiple accounts and virtual private clouds (VPC). You can register your Lambda functions as targets with a VPC Lattice target group, and configure a listener rule to forward requests to the target group for your Lambda function.
In this PR we create a new resolver to support VPC Lattice.
User experience
Customers can use this new resolver to get the benefits of using the Event Handler utility.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.