-
Notifications
You must be signed in to change notification settings - Fork 421
refactor(event_source): centralizing helper functions for query, header and base64 #2496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(event_source): centralizing helper functions for query, header and base64 #2496
Conversation
LGTM after you refactor to use kwargs over args in for |
Good to go.... still don't have my access fixed :/ |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2496 +/- ##
===========================================
- Coverage 97.15% 97.12% -0.03%
===========================================
Files 157 158 +1
Lines 7345 7346 +1
Branches 533 517 -16
===========================================
- Hits 7136 7135 -1
Misses 160 160
- Partials 49 51 +2
☔ View full report in Codecov by Sentry. |
Issue number: #2424
Summary
Changes
This PR unifies all the helper functions in one file to avoid drifts and fix minor problems in event source data classes.
User experience
There is no change in the user experience.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.