Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Idempotency helper utility #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Idempotency helper utility #245
Changes from 15 commits
d503fb0
e564c63
c4d19ba
45d384b
13e5b09
1efc27d
546e879
60fd336
ee46124
acab091
2a364fd
4f5d52b
a19d955
0ef52f9
d128b0a
4caa52c
d89fcee
ed9e0c2
7000927
c4856fd
aed4a7b
3b6c2e3
2047d34
8a054cb
523535f
834db1c
24f6187
41d559e
dca02ee
b4490b9
43b72e7
88e983e
d17275d
83d78ce
4bdfdf6
9de6e29
a4cc61a
978a6bb
1fd8b5a
022739e
8a2d4fe
e6f2d98
4aa8145
c54952c
7832e56
fed58fe
b079387
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Should we explain how it'll work under the hood here? This could help clarify how often this will call DynamoDB, what parameters it'll look at to decide if it's an idempotent request or not, etc.
Question: Should we mention how this stores the event into DynamoDB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we address this it should be in the documentation. Happy to make changes to the docs based on feedback!