-
Notifications
You must be signed in to change notification settings - Fork 421
feat(event_source): decode nested messages on SQS events #2349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
@leandrodamascena @rafaelgsr what's the status of this PR? What's needed? |
reiterating the ask @leandrodamascena @rafaelgsr before we take over |
@heitorlessa @rubenfonseca hey folks, sorry my delayed response. I was on vacations and then on a business trip. I'll resume working on this next week and come up with a proposal based on what @cowsandmilk mentioned. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2349 +/- ##
========================================
Coverage 97.23% 97.23%
========================================
Files 161 161
Lines 7415 7426 +11
Branches 538 538
========================================
+ Hits 7210 7221 +11
Misses 158 158
Partials 47 47
☔ View full report in Codecov by Sentry. |
…, decoded_nested_sns_event instead of decode_nested_sns_event)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you @rafaelgsr !
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #2348
Summary
Changes
Adding
decode_nested_s3_event
anddecode_nested_sns_event
functions onSQSEvent
to decode nested events originated from S3 and SNS, respectively.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.