-
Notifications
You must be signed in to change notification settings - Fork 421
feat(feature_flags): add modulo range condition for segmented experimentation support #2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feature_flags): add modulo range condition for segmented experimentation support #2331
Conversation
Hello @ajwad-shaikh! Thank you for submitting the PR! We are planning to start the review in the next week. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2331 +/- ##
===========================================
+ Coverage 97.16% 97.18% +0.01%
===========================================
Files 155 155
Lines 7067 7093 +26
Branches 515 520 +5
===========================================
+ Hits 6867 6893 +26
Misses 157 157
Partials 43 43
☔ View full report in Codecov by Sentry. |
Looking at this now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations for this awesome PR. I loved how you added documentation in the right places, and how you highlighted real use cases and samples in the documentation. This is stellar work!
…entation support (#2331) Co-authored-by: Leandro Damascena <[email protected]> Co-authored-by: Ruben Fonseca <[email protected]>
…entation support (aws-powertools#2331) Co-authored-by: Leandro Damascena <[email protected]> Co-authored-by: Ruben Fonseca <[email protected]>
Issue number: #2003
Summary
Adds Support for Modulo Range Condition in Feature Flags Utility
Changes
MODULO_RANGE
time_conditions.py
tocomparators.py
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? No.
RFC issue number: #2003
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.