-
Notifications
You must be signed in to change notification settings - Fork 421
chore(ci): create PRs not push #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): create PRs not push #2226
Conversation
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Found a problem we can discuss tomorrow in more detail on best way to approach it.
This will fail in the new secure model, because you won't be able to push directly - Don't have a good idea for that yet, so leaving it here for discussion. Known constraints
Avenues that are possible as of now
|
summary: extend publish_docs to support git reference (temp branch id) make reusable_update_v2_layer_arn_docs redundant lower permissions
problem solved!! I extended the workflow that publish documentation to optionally pull from a different branch or commit ID. Then, I separated creating a PR for docs, and then updating the docs like we used to but now using the temporary branch that hasn't yet being merged. This PR is quite critical and might be easy to overlook a few areas, so I'll break this PR down now that I've got a working solution. I'll create separate PRs for:
|
First PR created: #2238 |
This PR is no longer necessary, closing shortlyBroken down into multiple PRs to ease reviewing (in order): |
Interessante... |
@heitorlessa 1 and 2 are the same, is this right? |
Issue number: #2210
No longer necessary, closing shortly
Broken down into multiple PRs to ease reviewing (in order):
Summary
Move to new model of creating PR for specific staged changes
Changes
post_release
job to reduce permissionsOptional
Git client setup and refresh tip
job step everywhereUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.