-
Notifications
You must be signed in to change notification settings - Fork 421
feat(event_sources): add AWS Config Rule event data class #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_sources): add AWS Config Rule event data class #2175
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2175 +/- ##
===========================================
+ Coverage 97.15% 97.22% +0.06%
===========================================
Files 156 157 +1
Lines 7103 7306 +203
Branches 519 523 +4
===========================================
+ Hits 6901 7103 +202
Misses 158 158
- Partials 44 45 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of great work! Just left a small change in the highlights of the docs.
This looks great, I was running in to this issue yesterday whilst building my first Custom Config rule and was about to build my own data structure to handle the incoming events. This looks to be exactly what is needed. I look forward to this being merged. Thanks for the efforts! |
Hi @austindimmer! It's amazing to hear that. We are reaching out to the AWS Config team just to confirm some information about these schemas, but we will definitely do our best to get this merged as soon as possible. Thanks. |
Hey, everyone! We haven't received any updates from the AWS Config team regarding event/schema validation and are moving forward with this PR. Until we get feedback from our customers that this feature is working as expected, we will not be adding Parser support. @rubenfonseca, can you review this, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing, thank you for the great work @leandrodamascena !
Issue number: #1667
Summary
Changes
In this PR we are adding the 3 types of events that can trigger a Lambda from an AWS Config rule.
These events are:
User experience
BEFORE
AFTER
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.