Skip to content

fix(e2e): fix test brittleness #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2023
Merged

fix(e2e): fix test brittleness #2152

merged 2 commits into from
Apr 20, 2023

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Apr 20, 2023

Issue number: #2151

Summary

Changes

Please provide a summary of what's being changed

This PR makes two changes that fixes E2E tests brittleness and fixes E2E tests running under Python 3.7.

User experience

Please share what the user experience looks like before and after this change

After this change, E2E tests should pass consistently.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca rubenfonseca requested a review from a team as a code owner April 20, 2023 13:01
@rubenfonseca rubenfonseca requested review from heitorlessa and removed request for a team April 20, 2023 13:01
@boring-cyborg boring-cyborg bot added the tests label Apr 20, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 20, 2023
@rubenfonseca rubenfonseca linked an issue Apr 20, 2023 that may be closed by this pull request
@github-actions github-actions bot added the bug Something isn't working label Apr 20, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (a77832c) 97.48% compared to head (5920535) 97.48%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2152   +/-   ##
========================================
  Coverage    97.48%   97.48%           
========================================
  Files          147      147           
  Lines         6836     6844    +8     
  Branches       497      497           
========================================
+ Hits          6664     6672    +8     
  Misses         136      136           
  Partials        36       36           

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!
image

@rubenfonseca rubenfonseca merged commit 6d466f4 into develop Apr 20, 2023
@rubenfonseca rubenfonseca deleted the rf/fix-e2e branch April 20, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: e2e tests are brittle and fail on python 3.7
3 participants