-
Notifications
You must be signed in to change notification settings - Fork 420
chore(ci): add support for x86-64 regions only #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f0a14f
to
afe65fd
Compare
@leandrodamascena unfortunately there's no easy to way to test this. So please check the code to see if it makes sense, and after we merge we can try a couple of workflows to see if any change is needed. |
layer/layer/layer_stack.py
Outdated
**kwargs | ||
) -> None: | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity. Any reason to remove the None
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry no, I'll re-add it to make it more explicit.
The code makes perfect sense to me, but like you said: there's no way to test it and just looking at the code I have no idea if we need to change anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
e210717
to
6cf86a9
Compare
Issue number: #1950
Summary
Changes
This PR changes our Layer and Canary stack to support regions that only support x86_64 Lambdas. We couldn't find an easy and reliable way to
detect dinamically if a given region supports ARM64 Lambdas, so instead we maintain the map manually and indicate which regions don't support it.
This makes heavy use of CDK/CloudFormation Parameters and Conditions, so the same CloudFormation template can be used across all regions.
User experience
After this change, we will generate Lambda Layers for regions that only support x86_64 Lambdas. We will need to update the documentation when the
first Layer version is generated, and validate that the script to update the layer version in the docs works with the single-architecture regions.
Regions that will be added by this PR
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.