Skip to content

chore(ci): add support for x86-64 regions only #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Apr 13, 2023

Issue number: #1950

Summary

Changes

Please provide a summary of what's being changed

This PR changes our Layer and Canary stack to support regions that only support x86_64 Lambdas. We couldn't find an easy and reliable way to
detect dinamically if a given region supports ARM64 Lambdas, so instead we maintain the map manually and indicate which regions don't support it.

This makes heavy use of CDK/CloudFormation Parameters and Conditions, so the same CloudFormation template can be used across all regions.

User experience

Please share what the user experience looks like before and after this change

After this change, we will generate Lambda Layers for regions that only support x86_64 Lambdas. We will need to update the documentation when the
first Layer version is generated, and validate that the script to update the layer version in the docs works with the single-architecture regions.

Regions that will be added by this PR

  • ap-south-2
  • ap-southeast-4
  • eu-central-2
  • eu-south-2
  • me-central-1

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca rubenfonseca requested a review from a team as a code owner April 13, 2023 14:20
@rubenfonseca rubenfonseca requested review from leandrodamascena and removed request for a team April 13, 2023 14:20
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code labels Apr 13, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 13, 2023
@rubenfonseca rubenfonseca linked an issue Apr 13, 2023 that may be closed by this pull request
2 tasks
@rubenfonseca rubenfonseca force-pushed the rf/allow-x86-64-only-regions branch from 3f0a14f to afe65fd Compare April 13, 2023 14:23
@rubenfonseca
Copy link
Contributor Author

@leandrodamascena unfortunately there's no easy to way to test this. So please check the code to see if it makes sense, and after we merge we can try a couple of workflows to see if any change is needed.

@github-actions github-actions bot added the internal Maintenance changes label Apr 13, 2023
**kwargs
) -> None:
):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity. Any reason to remove the None here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry no, I'll re-add it to make it more explicit.

@leandrodamascena
Copy link
Contributor

@leandrodamascena unfortunately there's no easy to way to test this. So please check the code to see if it makes sense, and after we merge we can try a couple of workflows to see if any change is needed.

The code makes perfect sense to me, but like you said: there's no way to test it and just looking at the code I have no idea if we need to change anything else.
So, I follow you: let's merge this PR and check for possible changes. I'll approve.

@leandrodamascena leandrodamascena self-requested a review April 13, 2023 17:12
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@rubenfonseca rubenfonseca force-pushed the rf/allow-x86-64-only-regions branch from e210717 to 6cf86a9 Compare April 14, 2023 10:49
@rubenfonseca rubenfonseca merged commit 52b1554 into develop Apr 14, 2023
@rubenfonseca rubenfonseca deleted the rf/allow-x86-64-only-regions branch April 14, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Adding new AWS Regions to the Lambda Layers Deployment
2 participants