Skip to content

fix(ci): update layer version on logger, tracer and metrics docs #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

rubenfonseca
Copy link
Contributor

Issue number: #1969

Summary

Changes

Please provide a summary of what's being changed

This change extends the script that replaces the Lambda Layer version to include the examples found in Logger, Tracer and Metrics.

User experience

Please share what the user experience looks like before and after this change

After this change, the Lambda Layer version will get automatically updated on Logger, Tracer and Metrics everytime we make a new release.

NOTE: After merging, we can test the changes by running the Deploy v2 layer to all regions job.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca rubenfonseca requested a review from a team as a code owner April 12, 2023 08:52
@rubenfonseca rubenfonseca requested review from leandrodamascena and removed request for a team April 12, 2023 08:52
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2023
@github-actions github-actions bot added the bug Something isn't working label Apr 12, 2023
@rubenfonseca rubenfonseca added the documentation Improvements or additions to documentation label Apr 12, 2023
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@leandrodamascena leandrodamascena merged commit 20d6950 into develop Apr 12, 2023
@leandrodamascena leandrodamascena deleted the rf/update-layer-version branch April 12, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Automate the layer version update in the Tracer, Logger and Metrics documentation.
2 participants