Skip to content

chore(maintenance): validate acknowledgement section is present #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #1334

Summary

Changes

Added a new check in the https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/.github/workflows/on_opened_pr.yml action to validate if the customer agreed with our terms.

User experience

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner April 11, 2023 23:54
@leandrodamascena leandrodamascena requested review from heitorlessa and removed request for a team April 11, 2023 23:54
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Apr 11, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2023
@github-actions github-actions bot added the internal Maintenance changes label Apr 11, 2023
Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is great Leo! Good stuff!

@leandrodamascena leandrodamascena merged commit 104be8f into aws-powertools:develop Apr 12, 2023
@leandrodamascena leandrodamascena linked an issue Apr 12, 2023 that may be closed by this pull request
2 tasks
@heitorlessa
Copy link
Contributor

👏 👏 👏 fantastic!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Enforce PR Acknowledgement is present
3 participants