feat(idempotency): allow custom sdk clients in DynamoDBPersistenceLayer #2087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
heitorlessa
requested review from
leandrodamascena
and removed request for
a team
pull-request-size
bot
added
the
size/L
heitorlessa
changed the title
7 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2087 +/- ##
========================================
Coverage 97.45% 97.45%
========================================
Files 146 146
Lines 6748 6750 +2
Branches 477 478 +1
========================================
+ Hits 6576 6578 +2
Misses 136 136
Partials 36 36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
rubenfonseca
approved these changes
Apr 5, 2023
|
Walked @leandrodamascena through the changes in a peer review. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2073
Summary
Changes
This PR adds a new constructor parameter
boto3_clientinDynamoDBPersistenceLayer. This unblocks customers wanting to use DynamoDB Local, LocalStack, or AWS SDK Stubbers more cleanly (no private attribute access).It also unblocks the documentation PR where we're trying to provide an example of how to use DynamoDB Local for testing.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.