Skip to content

docs(parser): fix highlighted line #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

michael-k
Copy link
Contributor

@michael-k michael-k commented Mar 29, 2023

Issue number: #2079

Summary

Changes

Please provide a summary of what's being changed

Highlight line with event_parser decorator instead of empty line.

https://awslabs.github.io/aws-lambda-powertools-python/2.11.0/utilities/parser/#parsing-events

User experience

Please share what the user experience looks like before and after this change

Before:

image

After:

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@michael-k michael-k requested a review from a team as a code owner March 29, 2023 16:24
@michael-k michael-k requested review from rubenfonseca and removed request for a team March 29, 2023 16:24
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Mar 29, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 29, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 29, 2023
@michael-k michael-k force-pushed the docs/fix-parser-highlighted-line branch from 552fc67 to 9979503 Compare April 2, 2023 15:30
@rubenfonseca rubenfonseca added the need-issue PRs that are missing related issues label Apr 3, 2023
@rubenfonseca rubenfonseca linked an issue Apr 3, 2023 that may be closed by this pull request
1 task
@rubenfonseca rubenfonseca added parser Parser (Pydantic) utility and removed need-issue PRs that are missing related issues labels Apr 3, 2023
@rubenfonseca
Copy link
Contributor

Thank you so much for your contribution @michael-k! As stated in our CONTRIBUTING guide all pull requests require an Issue first. So I went ahead and created one for you.

I've also took the change to fix another highlight that was incorrect on that page.

Thank you for your contribution!

@rubenfonseca rubenfonseca merged commit 4901919 into aws-powertools:develop Apr 3, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 3, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@rubenfonseca rubenfonseca self-assigned this Apr 3, 2023
@michael-k michael-k deleted the docs/fix-parser-highlighted-line branch April 3, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation parser Parser (Pydantic) utility size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Fix the highlight positions on event parser
2 participants