-
Notifications
You must be signed in to change notification settings - Fork 421
fix(tests): make logs fetching more robust #1878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 97.51% // Head: 97.51% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1878 +/- ##
========================================
Coverage 97.51% 97.51%
========================================
Files 143 143
Lines 6570 6570
Branches 466 466
========================================
Hits 6407 6407
Misses 128 128
Partials 35 35 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX change and complexity baseline suggestion.
Thanks for spotting this, we did the same in TraceFetcher
before after hitting eventual consistency too.
Co-authored-by: Heitor Lessa <[email protected]> Signed-off-by: Ruben Fonseca <[email protected]>
Co-authored-by: Heitor Lessa <[email protected]> Signed-off-by: Ruben Fonseca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
Issue number: #1877
Summary
Changes
This PR adds an optional field to the logger fetcher, where we could indicate how many
lines of logging we are expecting. If we fail to fetch that number, we use the existing
retry mechanism to try multiple times, before bailing out.
User experience
This should help with some of the flaky e2e tests.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.