-
Notifications
You must be signed in to change notification settings - Fork 421
feat(apigateway): introduce specialized routers for typing #1824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigateway): introduce specialized routers for typing #1824
Conversation
Codecov ReportBase: 97.59% // Head: 97.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1824 +/- ##
========================================
Coverage 97.59% 97.59%
========================================
Files 141 142 +1
Lines 6434 6444 +10
Branches 444 444
========================================
+ Hits 6279 6289 +10
Misses 123 123
Partials 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rubenfonseca! Another incredible PR! Everything worked as expected here and I just added more details in the example just to make sure the user has a full example of use.
Issue number: #1781
Summary
Changes
This PR implements the following changes:
User experience
Before the change, you would not get type hints from your IDE when accessing the
current_event
property of your splitted router.After this change, you can use a specialized router for each kind of event source, and get access to the specialized events:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.