fix(parameters): get_secret correctly return SecretBinary value

[mangoes-git]

Issue number: #1713

Summary

Changes

parameters.get_secret can now fetch Binary Secrets.

User experience

Before this patch, calling parameters.get_secret to get a Binary Secret will throw a GetParameterError since it would only try to retrieve the SecretString value from the secret value. Ref: #1713

Now, get_secret will correctly fetch Binary Secrets.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[boring-cyborg]

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

[codecov-commenter]

Codecov Report

Base: 99.27% // Head: 99.27% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c82d6d2) compared to base (8862e69).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1717   +/-   ##
========================================
  Coverage    99.27%   99.27%           
========================================
  Files          129      129           
  Lines         6056     6059    +3     
  Branches       402      403    +1     
========================================
+ Hits          6012     6015    +3     
  Misses          20       20           
  Partials        24       24           

Impacted Files	Coverage Δ
..._lambda_powertools/utilities/parameters/secrets.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[heitorlessa]

thank you so much @mangoes-git - I've just added tests and a minor code style (removed else). Merging

[boring-cyborg]

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!