Skip to content

fix: remove DeleteMessageBatch call to SQS api if there are no messages to delete #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion aws_lambda_powertools/utilities/batch/sqs.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ def _clean(self):
queue_url = self._get_queue_url()
entries_to_remove = self._get_entries_to_clean()

delete_message_response = self.client.delete_message_batch(QueueUrl=queue_url, Entries=entries_to_remove)
delete_message_response = None
if entries_to_remove:
delete_message_response = self.client.delete_message_batch(QueueUrl=queue_url, Entries=entries_to_remove)

if self.suppress_exception:
logger.debug(f"{len(self.fail_messages)} records failed processing, but exceptions are suppressed")
Expand Down
15 changes: 15 additions & 0 deletions tests/functional/test_utilities_batch.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,3 +275,18 @@ def lambda_handler(event, context):

stubber.assert_no_pending_responses()
assert result is True


def test_partial_sqs_processor_context_only_failure(sqs_event_factory, record_handler, partial_processor):
"""
Test processor with only failures
"""
first_record = sqs_event_factory("fail")
second_record = sqs_event_factory("fail")

records = [first_record, second_record]
with pytest.raises(SQSBatchProcessingError) as error:
with partial_processor(records, record_handler) as ctx:
ctx.process()

assert len(error.value.args[0]) == 2