-
Notifications
You must be signed in to change notification settings - Fork 421
feat(event_source): deserialize dynamodb new_image, old_image as dict #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_source): deserialize dynamodb new_image, old_image as dict #1580
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Do I need to update the public docs for this change? |
Hi @shanab! First of all thank you so much for submitting this PR and helping to improve this project! It looks like we have errors in the pipeline. Could you check for errors and fix them? We suggest running |
Thanks @leandrodamascena! I've fixed the typing errors. |
Awesome @shanab! I'll review this PR this week and let you know if we need to fix anything, ok? BTW, we can update the documentation for you, but let us know if you want to update this and push the code 🥇 . Thank you! |
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@shanab a few questions if I may as I'm only seeing this now:
I think what I'm missing is the customer experience after you get the data deserialised like that vs a Dict and its values - v2 is just around the corner, we might simplify maintenance and perf by making any necessary breaking change. Thanks a lot |
Bumps [mypy-boto3-ssm](https://github.com/youtype/mypy_boto3_builder) from 1.24.81 to 1.24.90. - [Release notes](https://github.com/youtype/mypy_boto3_builder/releases) - [Commits](https://github.com/youtype/mypy_boto3_builder/commits) --- updated-dependencies: - dependency-name: mypy-boto3-ssm dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Thanks for accepting a 1:1 call on this @shanab ! Here's a quick recap on the conditions we could make it this work if we can get it done until Thursday to not impact V2 launch:
|
Co-authored-by: Rúben Fonseca <[email protected]> Co-authored-by: Leandro Damascena <[email protected]>
….1 (#1611) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…y TypeDeserializer
I've agreed with @rubenfonseca to move to a new PR, as the diff just blew up once I changed the base branch from develop to v2. |
Link to the new PR: #1619 |
Issue number: #1432
Summary
Add
DynamoDBImageDeserializer
class to data classes. The class can be used to parse DynamoDB StreamRecord's old_image and new_image properties of typeDict[str, AttrValue]
to Dict with Python types.Changes
DynamoDBImageDeserializer
class to data classes.User experience
Users will be able to convert a StreamRecord's complex image type into a Python dictionary with Python types; without needing to recurse through the data.
Example:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
No
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.