Skip to content

chore(ci): add linter for GitHub Actions as pre-commit hook #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build_changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ on:

jobs:
changelog:
needs: release
uses: ./.github/workflows/reusable_publish_changelog.yml
2 changes: 0 additions & 2 deletions .github/workflows/on_opened_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: "Debug workflow_run event"
run: echo "${{ github }}"
- name: "Ensure related issue is present"
uses: actions/github-script@v6
env:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/python_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
matrix:
python-version: [3.7, 3.8, 3.9]
env:
OS: ${{ matrix.os }}
PYTHON: ${{ matrix.python-version }}
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -56,6 +55,6 @@ jobs:
with:
file: ./coverage.xml
# flags: unittests
env_vars: OS,PYTHON
env_vars: PYTHON
name: aws-lambda-powertools-python-codecov
# fail_ci_if_error: true # failing more consistently making CI unreliable despite all tests above passing
3 changes: 3 additions & 0 deletions .github/workflows/reusable_deploy_layer_stack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ on:
workflow_call:
inputs:
stage:
description: "Deployment stage (BETA, PROD)"
required: true
type: string
artefact-name:
description: "CDK Layer Artefact name to download"
required: true
type: string
environment:
description: "GitHub Environment to use for encrypted secrets"
required: true
type: string

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/reusable_export_pr_details.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@ on:
workflow_call:
inputs:
record_pr_workflow_id:
description: "Record PR workflow execution ID to download PR details"
required: true
type: number
workflow_origin: # see https://github.com/awslabs/aws-lambda-powertools-python/issues/1349
description: "Repository full name for runner integrity"
required: true
type: string
secrets:
token:
description: "GitHub Actions temporary and scoped token"
required: true
# Map the workflow outputs to job outputs
outputs:
Expand Down
5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,8 @@ repos:
hooks:
- id: cfn-python-lint
files: examples/.*\.(yaml|yml)$
- repo: https://github.com/rhysd/actionlint
rev: v1.6.16
hooks:
- id: actionlint-docker
args: [-pyflakes=]