Skip to content

fix(ci): keep layer version permission resource #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2022
Merged

fix(ci): keep layer version permission resource #1318

merged 1 commit into from
Jul 19, 2022

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Jul 19, 2022

Issue number:

Summary

Changes

While we can keep the previous layer version, the default removal policy on the permission is DESTROY. Thus deploying new version keeps layer version but removes the permission, so it is no longer publicly accessible. Thus, we need to use low level construct CfnLayerVersionPermission and set the removal policy.

This bug has been reported to the CDK upstream project: aws/aws-cdk#21232

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 19, 2022
@am29d am29d requested a review from heitorlessa July 19, 2022 15:07
@github-actions github-actions bot added the bug Something isn't working label Jul 19, 2022
@am29d am29d marked this pull request as ready for review July 19, 2022 15:10
@heitorlessa heitorlessa changed the title fix(ci): keep layer version permission fix(ci): keep layer version permission resource Jul 19, 2022
@heitorlessa heitorlessa merged commit b6ed979 into aws-powertools:develop Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants