fix(logger): support additional args for handlers when injecting lambda context #1276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1277
Summary
Changes
Preserve
args
andkwargs
in thelogger.inject_lambda_context
decoratorUser experience
After @heitorlessa 's talk at our meetup last Thursday I tried to add the logger to our project. The lambda handler was already decorated with a couple of decorators, one of which injects additional parameters into the handler. The decorator did not support this, simply passing on args and kwargs fixes this issue and allows the decorator to be used on lambda handlers that support additional arguments.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.