fix(capture_method): should yield inside with for generator method using a context manager #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * capture_method should yield from within the "with" statement * Add missing test cases Closes #112
Codecov Report
@@ Coverage Diff @@
## develop #124 +/- ##
============================================
+ Coverage 98.99% 100.00% +1.00%
============================================
Files 24 24
Lines 698 698
Branches 64 64
============================================
+ Hits 691 698 +7
+ Misses 7 0 -7
Continue to review full report at Codecov.
|
michaelbrewer
changed the title
to-mc
approved these changes
Aug 22, 2020
michaelbrewer
referenced
this pull request
in gyft/aws-lambda-powertools-python
Aug 22, 2020
Changes: * capture_method should yield from within the "with" statement * Add missing test cases Closes #112
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Aug 22, 2020
* develop: chore: version bump to 1.3.1 fix(capture_method): should yield inside with (#124) chore: bump version to 1.3.0 (#122) chore(deps): bump prismjs from 1.20.0 to 1.21.0 in /docs chore(deps): bump elliptic from 6.5.2 to 6.5.3 in /docs feat: add parameter utility (#96) chore: bump version to 1.2.0 (#119) feat: add support for tracing of generators using capture_method decorator (#113)
nmoutschen
pushed a commit
that referenced
this pull request
Aug 24, 2020
* fix(ssm): Make decrypt an explicit option * chore: declare as self * fix: update get_parameter and get_parameters Changes: ssm.py - get_parameters - pass through the **sdk_options and merge in the recursive and decrypt params ssm.py - get_parameter - add explicit option for decrypt * chore: fix typos and type hinting * tests: verify that the default kwargs are set - `decrypt` should be false by default - `recursive` should be true by default * fix(capture_method): should yield inside with (#124) Changes: * capture_method should yield from within the "with" statement * Add missing test cases Closes #112 * chore: version bump to 1.3.1 * refactor: reduce get_multiple complexity Changes: - base.py - update get_multiple to reduce the overall complexity - base.py - `_has_not_expired` returns whether a key exists and has not expired - base.py - `transform_value` add `raise_on_transform_error` and default to True - test_utilities_parameters.py - Add a direct test of transform_value * refactor: revert to a regular for each Changes: * Add type hint to `values` as it can change later on in transform * Use a slightly faster and easier to read for each over dict comprehension Co-authored-by: Tom McCarthy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Closes #112
Issue #, if available:
#112
Description of changes:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.