-
Notifications
You must be signed in to change notification settings - Fork 421
feat(event_handler): Allow for cookies in response #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes: - Add cookies field in Response - For http api gateway format 2.0 responses serialize to cookies - For alb and rest api use multiValueHeaders closes aws-powertools#1192
Codecov Report
@@ Coverage Diff @@
## develop #1196 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 119 119
Lines 5423 5429 +6
Branches 618 620 +2
========================================
+ Hits 5417 5423 +6
Misses 2 2
Partials 4 4
Continue to review full report at Codecov.
|
In an effort to prevent you from wasting time, you should wait for issues to prioritised, this won't be merged for a long time until we're ready to add new features. |
More of a gap than a feature. There is no easy way for customers to set |
Issue number:
Summary
Currently there is no simple way to set cookies in the api gateway event handler.
And this is a gap for http api responses which supports a
cookie
field.For documentation we may need to call out the following caveats:
multiValueHeaders
is assumed for rest and alb, but only supported by ALB when enabled: ALB - Enable multi-value headerscookies
is assumed for http api but only supported by http api payload version 2Changes
cookies
field in Responsecookies
multiValueHeaders
for cookiesUser experience
For http api handler
Will output a http api payload v2 response:
For rest api handler
Outputs the following for ALB and Rest responses
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.