-
Notifications
You must be signed in to change notification settings - Fork 420
docs(batch): extract and fix examples #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Extract examples for batch - Fix python syntax - Fix yaml synxtax Related to - aws-powertools#1064
Codecov Report
@@ Coverage Diff @@
## develop #1114 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 119 119
Lines 5423 5423
Branches 618 618
========================================
Hits 5417 5417
Misses 2 2
Partials 4 4 Continue to review full report at Codecov.
|
batch
docs examples
batch
docs examplesbatch
docs examples
batch
docs examplesbatch processing
docs examples
batch processing
docs examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
internal
Maintenance changes
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Summary
Extract code examples from the batch documentation
Changes
Changes:
make
tasks to format, compile and lint examples to prevent future errorsBug fixes in this PR:
success_handler
Batch - Creating a custom batch processor example ( See issue Docs: Batch - creating a custom batch processor example has python syntax errors #1209 )Missing closing quote ["]
) in Batch -Testing your code examples ( See issue Docs: Batch - Testing your code examples has syntax errors #1211 )Extending failure handling mechanism in BatchProcessor
exampleCustomizing boto configuration
exampleAccessing processed messages via context manager
example removing unused imports and fix line highlights.User experience
Code examples can now be used without syntax errors
Hosted version is here: https://gyft.github.io/aws-lambda-powertools-python/latest/
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.