Skip to content

fix(logger): exclude source_logger in copy_config_to_registered_loggers #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2022
Merged

fix(logger): exclude source_logger in copy_config_to_registered_loggers #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d6395b
bug: fix default exclusion of source_logger in copy_config_to_registe…
Feb 4, 2022
8b61e39
fix code comment
Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws_lambda_powertools/logging/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def copy_config_to_registered_loggers(
if exclude:
exclude.add(source_logger.name)
else:
exclude = set(source_logger.name)
exclude = {source_logger.name}

# Prepare loggers set
if include:
Expand Down
11 changes: 11 additions & 0 deletions tests/functional/test_logger_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,3 +182,14 @@ def test_copy_config_to_ext_loggers_custom_log_level(stdout, logger, log_level):
assert logger.level == log_level.WARNING.value
assert log["message"] == msg
assert log["level"] == log_level.WARNING.name


def test_copy_config_to_ext_loggers_should_not_break_append_keys(stdout, logger, log_level):
# GIVEN powertools logger initialized
powertools_logger = Logger(service=service_name(), level=log_level.INFO.value, stream=stdout)

# WHEN configuration copied from powertools logger to ALL external loggers
utils.copy_config_to_registered_loggers(source_logger=powertools_logger)

# THEN append_keys should not raise an exception
powertools_logger.append_keys(key="value")