-
Notifications
You must be signed in to change notification settings - Fork 421
Add add_metadata in the metrics feature #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
feature-request
feature request
Comments
heitorlessa
referenced
this issue
in heitorlessa/aws-lambda-powertools-python
Jun 15, 2020
heitorlessa
referenced
this issue
in heitorlessa/aws-lambda-powertools-python
Jun 15, 2020
Signed-off-by: heitorlessa <[email protected]>
Thanks for opening the issue Pablo! I'm just waiting an approval of the final implementation we discussed, and it will be available in 1.0.0 |
heitorlessa
added a commit
that referenced
this issue
Jun 16, 2020
* chore: remove Logger deprecated code * chore: remove Metrics deprecated code * chore: remove models from deprecated code * chore: move logger formatter to its own file * chore: cleanup metrics tests * chore: cleanup tracer tests * chore: cleanup logger tests * chore: cleanup tracer tests * chore: set test coverage to 90% min Signed-off-by: heitorlessa <[email protected]> * feat: add metrics metadata #80 * docs: add metrics metadata #80 Signed-off-by: heitorlessa <[email protected]> * chore: refactor metric serialization * improv: test metadata with log_metrics * improv: test serialize metric with valid EMF object
It's now merged in If you need this feature as of now, you can install the dev version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the Problem/Issue
When publishing metrics, it's would be useful to be able to reference the specific values that generated the specific metric value.
For example, in one project I'm crawling some URLs. In this case I log the size of the fetched object as a metric. Being able to annotate that metric (add_property in the aws-embedded-metrics-python library) with the URL it's very useful when doing insights after. If I rely on Tracing info, this means I depend on xray and also will be affected by sampling.
Logging this in a structured logging, will separate the information from the metric, so parsing the logs will be much harder, so being able to add this info along with the metric publishing would be useful.
Describe the solution you'd like
Add an add_metadata or add_property method to metrics similar to the one found in aws-embedded-metrics-python
Describe alternatives you've considered
The text was updated successfully, but these errors were encountered: