Skip to content

Allow bring your own logger to Feature Flags #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gwlester opened this issue Sep 26, 2021 · 3 comments
Closed

Allow bring your own logger to Feature Flags #702

gwlester opened this issue Sep 26, 2021 · 3 comments
Labels
feature-request feature request p2

Comments

@gwlester
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Users would like to use a customized logger.

Describe the solution you'd like

Add the ability to pass a logger instance, defaulted to None into the object creation of the following classes:

  • AppConfigStore
  • FeatureFlags
  • SchemaValidator
  • FeaturesValidator
  • RulesValidator
  • ConditionsValidator

The init method would create a logger instance if None was passed in.

Describe alternatives you've considered

Additional context

@gwlester gwlester added feature-request feature request triage Pending triage from maintainers labels Sep 26, 2021
@gwlester
Copy link
Contributor Author

I attempted to push an implementation of this up to then create a push request, but it seems I'm not authorized.

Can I get added to the contributors list?

@to-mc
Copy link
Contributor

to-mc commented Sep 28, 2021

@gwlester you'll need to fork this repository then push your changes to a branch in your own fork. You can then create a PR from your own fork against this repo. If you're having issues, come ping us in #lambda-powertools on the AWS Developer Slack (invite if you need one) and we'll help.

@heitorlessa heitorlessa added the p2 label Sep 28, 2021
@heitorlessa heitorlessa added pending-release Fix or implementation already in dev waiting to be released and removed triage Pending triage from maintainers labels Oct 1, 2021
@heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa removed the pending-release Fix or implementation already in dev waiting to be released label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request feature request p2
Projects
None yet
Development

No branches or pull requests

3 participants