Skip to content

Include THIRD-PARTY-LICENSES in PyPI tarball #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BastianZim opened this issue Aug 21, 2021 · 9 comments · Fixed by #635
Closed

Include THIRD-PARTY-LICENSES in PyPI tarball #634

BastianZim opened this issue Aug 21, 2021 · 9 comments · Fixed by #635
Labels
feature-request feature request

Comments

@BastianZim
Copy link
Contributor

BastianZim commented Aug 21, 2021

Is your feature request related to a problem? Please describe.

Currently, THIRD-PARTY-LICENSES is not included in the PyPI tarball: https://pypi.org/project/aws-lambda-powertools/#files

Describe the solution you'd like

It would be great, if the THIRD-PARTY-LICENSES file is also included.

Describe alternatives you've considered

Additional context

I am the maintainer of the conda-forge feedstock and am currently manually including the file.

@BastianZim BastianZim added feature-request feature request triage Pending triage from maintainers labels Aug 21, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 21, 2021

Thanks for opening your first issue here! We'll come back to you as soon as we can.

@BastianZim
Copy link
Contributor Author

Happy to put in a PR if this is something that's acceptable.

@heitorlessa
Copy link
Contributor

heitorlessa commented Aug 21, 2021 via email

@BastianZim
Copy link
Contributor Author

Hi Heitor, awesome, have added the PR (At least that's where I think it's included). Thanks!

@heitorlessa
Copy link
Contributor

Thanks a lot @BastianZim foe the PR - merged it earlier. I'll ping here once we make a release in the coming weeks - we've got some new enhancements we want to work on first.

Also, first time I hear about conde feedstock, so thanks a lot for including us :-)

@BastianZim
Copy link
Contributor Author

My pleasure, thanks for merging @heitorlessa! Of course, nothing urgent on my side. I'm following the releases so no ping needed for me, just FYI. :)

Of course! Let me know if anyone here wants to be a maintainer there as well at some point.

@heitorlessa
Copy link
Contributor

Available now in PyPi as 1.20.1 ;)

@BastianZim
Copy link
Contributor Author

Thank you!

@BastianZim
Copy link
Contributor Author

@heitorlessa Would you mind opening the issue again? Unfortunately, the license is still not included: https://pypi.org/project/aws-lambda-powertools/#files
Not entirely sure why as I thought this is done through the Manifest but I have to admit that I'm not the greatest expert on python packaging so I'll try but am probably the wrong person to investigate this further.

@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants