Skip to content

Maintenance: Break down event_source_data_classes tests #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
heitorlessa opened this issue Jul 6, 2021 · 5 comments · Fixed by #2506
Closed

Maintenance: Break down event_source_data_classes tests #509

heitorlessa opened this issue Jul 6, 2021 · 5 comments · Fixed by #2506
Assignees
@leandrodamascena
Labels
event_sources Event Source Data Class utility help wanted Could use a second pair of eyes/hands tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Issue: #504

Functional tests for event source data classes utility are now 1.3K LOC in a single file. This issue tracks resolving them into a test per event source to ease maintenance and contrib
@heitorlessa heitorlessa added the internal Maintenance changes label Jul 6, 2021
@michaelbrewer
Copy link
Contributor

@heitorlessa - i don't mind splitting this up :)

@heitorlessa
Copy link
Contributor Author

heitorlessa commented Jul 24, 2021 via email

@michaelbrewer
Copy link
Contributor

@heitorlessa - do you think this is still necessary? These tests are extremely fast, so it is not for performance reasons. Going forward for new types of event sources, i will make sure to split out the tests. And if there is any major refactoring or changes to the existing ones.

@heitorlessa heitorlessa added event_sources Event Source Data Class utility and removed area/event_sources labels Nov 9, 2022
@heitorlessa heitorlessa added the help wanted Could use a second pair of eyes/hands label Mar 10, 2023
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 17, 2023
@sthulb sthulb moved this from Triage to Backlog in Powertools for AWS Lambda (Python) Jun 19, 2023
@leandrodamascena leandrodamascena mentioned this issue Jun 20, 2023
Merged
7 tasks
@leandrodamascena leandrodamascena linked a pull request Jun 20, 2023 that will close this issue
refactor(event_source): convert functional tests to unit tests #2506
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in Powertools for AWS Lambda (Python) Jun 23, 2023
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Jun 23, 2023
@leandrodamascena leandrodamascena self-assigned this Jun 26, 2023
@github-actions
Copy link
Contributor

This is now released under 2.19.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Jun 30, 2023
@rubenfonseca rubenfonseca moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
event_sources Event Source Data Class utility help wanted Could use a second pair of eyes/hands tech-debt Technical Debt tasks
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
No milestone
3 participants
@heitorlessa @leandrodamascena @michaelbrewer