Skip to content

Tech debt: Only infer type hints when necessary in parser_event decorator #4184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
leandrodamascena opened this issue Apr 23, 2024 · 1 comment · Fixed by #4183
Closed
1 of 2 tasks

Tech debt: Only infer type hints when necessary in parser_event decorator #4184

leandrodamascena opened this issue Apr 23, 2024 · 1 comment · Fixed by #4183
Labels
tech-debt Technical Debt tasks

Comments

@leandrodamascena
Copy link
Contributor

Why is this needed?

Opening this issue on behalf of @raymondbutcher

Currently the code always tries to infer types from the event argument, which makes code execution unnecessary when the model is not None.

Which area does this relate to?

Parser

Suggestion

Refactor the code a little to try to infer types only if model is None.

Acknowledgment
@leandrodamascena leandrodamascena added triage Pending triage from maintainers tech-debt Technical Debt tasks labels Apr 23, 2024
@leandrodamascena leandrodamascena mentioned this issue Apr 23, 2024
Merged
7 tasks
@leandrodamascena leandrodamascena linked a pull request Apr 23, 2024 that will close this issue
refactor(parser): only infer type hints when necessary #4183
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Triage to Coming soon in Powertools for AWS Lambda (Python) Apr 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Jun 10, 2024
@heitorlessa heitorlessa moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt Technical Debt tasks
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(parser): only infer type hints when necessary raymondbutcher/powertools-lambda-python
2 participants
@heitorlessa @leandrodamascena