Skip to content

Docs: Incorrect Highlighted Lines in Documentation #4117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Emerson-MM-Filho opened this issue Apr 11, 2024 · 8 comments · Fixed by #4131
Closed
1 task done

Docs: Incorrect Highlighted Lines in Documentation #4117

Emerson-MM-Filho opened this issue Apr 11, 2024 · 8 comments · Fixed by #4131
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Emerson-MM-Filho
Copy link
Contributor

Emerson-MM-Filho commented Apr 11, 2024

What were you searching in the docs?

I was searching for information on lambda context typing and how to deal with it in test cases. While reviewing the documentation, I noticed that the highlighted lines in the code snippet were incorrect.

Is this related to an existing documentation section?

https://docs.powertools.aws.dev/lambda/python/latest/utilities/typing/#working-with-context-methods-and-properties

How can we improve?

To improve the experience, ensuring that the highlighted lines in code snippets accurately reflect the relevant lines would enhance clarity and correctness in the documentation.

Got a suggestion in mind?

Update the highlighted lines in the file /examples/typing/src/working_with_context_function.py to correctly reflect lines 15, 22, and 23

while context.get_remaining_time_in_millis() > limit_execution:

"request_id": context.aws_request_id,
"remaining_time": context.get_remaining_time_in_millis(),

instead of lines 16, 25, and 26
comments: requests.Response = requests.get("https://jsonplaceholder.typicode.com/comments")

This change will ensure accuracy in the highlighted lines for clarity and correctness in the documentation.

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@Emerson-MM-Filho Emerson-MM-Filho added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Apr 11, 2024
@rubenfonseca
Copy link
Contributor

Looking at this now

@rubenfonseca
Copy link
Contributor

AMAZING ATTENTION TO DETAIL, thank you @Emerson-MM-Filho !! Would you like to submit a fix yourself? We would love your contribution on Powertools!

@rubenfonseca rubenfonseca removed the triage Pending triage from maintainers label Apr 12, 2024
@rubenfonseca rubenfonseca self-assigned this Apr 12, 2024
@rubenfonseca rubenfonseca moved this from Triage to Working on it in Powertools for AWS Lambda (Python) Apr 12, 2024
@Emerson-MM-Filho
Copy link
Contributor Author

AMAZING ATTENTION TO DETAIL, thank you @Emerson-MM-Filho !! Would you like to submit a fix yourself? We would love your contribution on Powertools!

Absolutely! I'm thrilled to hear that my attention to detail is appreciated. I'd be more than happy to submit a fix for Powertools. Let me know how I can get started! 🚀

@rubenfonseca
Copy link
Contributor

rubenfonseca commented Apr 12, 2024

@Emerson-MM-Filho super glad to hear :D Follow the "Development environment" and "Your first contribution" guide and send us a PR with the fix!

Specifically, in your case, you should edit the hl_lines commands that appear on the relevant documentation page. (e.g: here)

You can also verify if the fix looks good by generating the documentation locally with make docs-local

We're here to help so if you're stuck reach out here on on our Discord!

@Emerson-MM-Filho
Copy link
Contributor Author

Thanks so much for the opportunity, @rubenfonseca! I'm grateful for your encouragement and guidance.

Excited to contribute to Powertools! 🚀

@leandrodamascena
Copy link
Contributor

Excited to contribute to Powertools! 🚀

Amamos contribuções da comunidade, @Emerson-MM-Filho! 🚀

Thank you for helping us make Powertools for AWS Lambda even better.

@Emerson-MM-Filho
Copy link
Contributor Author

Thank you so much for the warm welcome, @leandrodamascena!

I'm thrilled to be a part of the community and excited to help make Powertools for AWS Lambda even better.

Emerson-MM-Filho added a commit to Emerson-MM-Filho/powertools-lambda-python that referenced this issue Apr 14, 2024
…n.py

Issue: aws-powertools#4117
Enhancing clarity and correctness in the documentation by accurately reflecting the relevant lines in the code snippet.
@rubenfonseca rubenfonseca linked a pull request Apr 15, 2024 that will close this issue
7 tasks
rubenfonseca pushed a commit to Emerson-MM-Filho/powertools-lambda-python that referenced this issue Apr 15, 2024
…n.py

Issue: aws-powertools#4117
Enhancing clarity and correctness in the documentation by accurately reflecting the relevant lines in the code snippet.
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Apr 15, 2024
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Shipped
3 participants