Skip to content

Logger: remove log record str conversion #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
heitorlessa opened this issue May 24, 2020 · 1 comment
Closed

Logger: remove log record str conversion #38

heitorlessa opened this issue May 24, 2020 · 1 comment
Assignees
@heitorlessa

Comments

@heitorlessa
Copy link
Contributor

Logger include some default logging expr, and that requires string interpolation using %.

That means not all types that are JSON serialized are supported such as bool, for example.

As part of last GA feature (docs #37), we should capture and do string interpolation for reserved logging expressions only e.g. %(asctime)s
@heitorlessa heitorlessa self-assigned this May 24, 2020
@heitorlessa
Copy link
Contributor Author

heitorlessa commented May 24, 2020 •
edited
Loading

Other areas that need updating:

heitorlessa added a commit that referenced this issue Jun 2, 2020
@heitorlessa
fix: str formatting for reserved keys only #38
fc86d17
heitorlessa added a commit that referenced this issue Jun 2, 2020
@heitorlessa
fix: cold_start value from str to actual bool #38
aadf150
heitorlessa added a commit that referenced this issue Jun 2, 2020
@heitorlessa
fix: memory_size value from str to actual int #38
e66138a
@heitorlessa heitorlessa mentioned this issue Jun 2, 2020
Merged
4 tasks
heitorlessa added a commit that referenced this issue Jun 2, 2020
@heitorlessa
Fix Logger value coercion to main keys (#53)
0cd7602 
* fix: str formatting for reserved keys only #38

* fix: cold_start value from str to actual bool  #38

* fix: memory_size value from str to actual int #38

* chore: linting
heitorlessa referenced this issue in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
@heitorlessa
Fix Logger value coercion to main keys (#53)
5618965 
* fix: str formatting for reserved keys only #38

* fix: cold_start value from str to actual bool  #38

* fix: memory_size value from str to actual int #38

* chore: linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heitorlessa heitorlessa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@heitorlessa