-
Notifications
You must be signed in to change notification settings - Fork 421
Checklist before GA #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@heitorlessa i was about to mention that the CHANGELOG.md file was not conforming to Keep a Changelog format. Which is probably why depedabot is not probably picking up the diff between releases. But i see you have it on your TODO list :) |
I’m kinda puzzled it’s not picking up - I initially thought it wasn’t
picking up because we had CHANGELOG in a subfolder.
I’ll have to setup a dummy project, a dummy package, and probably look into
dependabot code to understand how they fetch them.
I’ll create an issue to investigate that :)
…On Sun, 31 May 2020 at 05:46, Michael Brewer ***@***.***> wrote:
@heitorlessa <https://github.com/heitorlessa> i was about to mention that
the CHANGELOG.md file was not conforming to Keep a Changelog format
<https://keepachangelog.com/en/0.3.0/>. Which is probably why depedabot
is not probably picking up the diff between releases. But i see you have it
on your TODO list :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBCOWFJPZTKEV62EHM3RUHOI3ANCNFSM4NDABB4A>
.
|
@heitorlessa to be clear. It is picking up the changelog file. It is just not selecting the diff, because the sections in the changelog does not have anchors on the release names. So it shows the whole file. So by updating the format to be more of a “standard” it should do both. |
Ah! Thanks for clarifying - I've just merged a PR from Tom that converts
our CHANGELOG to Keep a Changelog format
…On Mon, 1 Jun 2020 at 04:44, Michael Brewer ***@***.***> wrote:
@heitorlessa <https://github.com/heitorlessa> to be clear. It is picking
up the changelog file. It is just not selecting the diff, because the
sections in the changelog does not have anchors on the release names. So it
shows the whole file.
So by updating the format to be more of a “standard” it should do both.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBDLMUWU3MRGCSQ6RNLRUMPZ7ANCNFSM4NDABB4A>
.
|
There are some great tools from conventional commit site that can generate this from you git commits and git tags. So you don’t have to had craft it. |
Yep - I checked them out. I’ll opt to partially generate the release notes,
but handcraft it as I didn’t like any generated Changelog I’ve seen out
there - It didn’t feel like it was for humans
…On Mon, 1 Jun 2020 at 18:04, Michael Brewer ***@***.***> wrote:
There are some great tools from conventional commit site that can generate
this from you git commits and git tags. So you don’t have to had craft it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBEU7MSTWI2NBIQ7MNLRUPNQ5ANCNFSM4NDABB4A>
.
|
@heitorlessa - CHANGELOG.md diffs are now 100% working with dependabot. |
@cakepietoast updated GA description to add a note that |
UPDATE:
Metrics.add_namespace
andPOWERTOOLS_METRICS_NAMESPACE
will be removed during GA.Creating a checklist of activities to remember after finishing docs website
Metrics
API with the core utilities (e.g. service param)Main docs website to live under/<runtime>
pytest
has now support forpyproject.toml
aws-lambda-powertools-python
Note - Checklist updated
We might need to break into multiple repos as most tools are language specific, docs layout are vastly different, and dependabot can't seem to get multiple CHANGELOGsThe text was updated successfully, but these errors were encountered: