Feature request: Parser support for custom resource

[ran-isenberg]

Use case

CFN Custom resource can trigger a lambda function with a set of events: create, delete and update.
There's a clear envelope and user payload which makes it a classic candidate for the parser.
I printed the actual events and wrote an event generator for testing purposes in my own application.
here's the gist: https://gist.github.com/ran-isenberg/9a49fad3d607245f7d615696353d1a36

Solution/User Experience

@event_parser(model=UserModel, envelope=envelopes.CustomResourceEnvelope)
def handler(event: UserModel, context: LambdaContext):
    assert event.password1 == event.password2

Alternative solutions

No response

Acknowledgment

• This feature request meets Lambda Powertools Tenets
• Should this be considered in other Lambda Powertools languages? i.e. Java, TypeScript, and .NET

[ran-isenberg]

I can work on it later this month if that's ok with you

[rubenfonseca]

For reference: typed structs from Go: https://github.com/aws/aws-lambda-go/blob/771b391678d3f54bfa38531774d656f5e0f2ab58/cfn/event.go

[heitorlessa]

Careful here, envelope could lead to resources being deleted: aws-powertools/powertools-lambda-java#1081

[on various meetings :/ so being brief]

[ran-isenberg]

@heitorlessa any unhandled exception can cause that. I think decorator usage in this case is less ideal. But regular parse function with try/except is fine.
Are you ok with me working on it nonetheless?
I'm planning a blog post on the subject and would like to showcase the parser too.

[ran-isenberg]

For reference: typed structs from Go: https://github.com/aws/aws-lambda-go/blob/771b391678d3f54bfa38531774d656f5e0f2ab58/cfn/event.go

it's similar to my gist, but it's not accurate 100%. OldResourceProperties does not appear in create/delete events. Only in update from my experience.

[heitorlessa]

It’s more complicated than error handling only - we had a ton of issues with custom resources in prod supporting internal teams. I’m totally supportive of having a Parser model but not an envelope — it’s easy to make mistakes and can be irreversible in some cases. For custom resources, we keep a cross-link to handle these tricky scenarios for that reason. https://github.com/aws-cloudformation/custom-resource-helper

…

On Mon, 22 May 2023 at 21:01, Ran Isenberg ***@***.***> wrote: For reference: typed structs from Go: https://github.com/aws/aws-lambda-go/blob/771b391678d3f54bfa38531774d656f5e0f2ab58/cfn/event.go it's similar to my gist, but it's not accurate 100%. OldResourceProperties does not appear in create/delete events. Only in update from my experience. — Reply to this email directly, view it on GitHub <#2295 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZPQBEYKQBI5ZU5XO5Q55DXHOZZ5ANCNFSM6AAAAAAYHM6I3E> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ran-isenberg]

@heitorlessa np, then model it is.
I'm familiar with the helper, we use it too.

[leandrodamascena]

Hi @ran-isenberg! So in this case, can you send the PR to add this support?

We are planning to release a version on Friday, so if you can send the PR by then we can include it in the next version, if not we will include it in the next release.

Thank you!

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.