Skip to content

Docs: Fix local tests example in the Idempotency Testing Your Code section #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
leandrodamascena opened this issue Mar 30, 2023 · 4 comments · Fixed by #2073
Closed
1 task done

Docs: Fix local tests example in the Idempotency Testing Your Code section #2072

leandrodamascena opened this issue Mar 30, 2023 · 4 comments · Fixed by #2073
Assignees
@leandrodamascena
Labels
documentation Improvements or additions to documentation idempotency Idempotency utility

Comments

@leandrodamascena
Copy link
Contributor

What were you searching in the docs?

Improve the documentation by changing the example to be more realistic.

Is this related to an existing documentation section?

Idempotency

How can we improve?

Changing documentation

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@leandrodamascena leandrodamascena added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Mar 30, 2023
@leandrodamascena leandrodamascena changed the title Docs: Change boto3 instance in idempotency testing example Docs: Fix local tests example Mar 30, 2023
@leandrodamascena leandrodamascena mentioned this issue Mar 30, 2023
Merged
7 tasks
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Mar 31, 2023
@heitorlessa
Copy link
Contributor

removing triage...

@heitorlessa heitorlessa added the idempotency Idempotency utility label Mar 31, 2023
@heitorlessa heitorlessa changed the title Docs: Fix local tests example Docs: Fix local tests example in the Idempotency Testing Your Code section Mar 31, 2023
@heitorlessa
Copy link
Contributor

only last comment before merging is that this part shouldn't work, please double check in case I'm wrong: https://github.com/awslabs/aws-lambda-powertools-python/pull/2073/files#diff-e612f95a3dbd33cabab2e49899653b8cc5d5e809bfad45aa54cdee41d22e5808R1253

Reason. Unless AWS SDK changed, the DynamoDB client wouldn't connect to DynamoDB Local because the client isn't being replaced, therefore it'd use the real DynamoDB external endpoint.

@heitorlessa heitorlessa linked a pull request Apr 3, 2023 that will close this issue
docs(idempotency): fixes to testing your code section #2073
Merged
7 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Apr 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

This is now released under 2.12.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
documentation Improvements or additions to documentation idempotency Idempotency utility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(idempotency): fixes to testing your code section leandrodamascena/aws-lambda-powertools-python
2 participants
@heitorlessa @leandrodamascena