Reusing Tracer across your code disables patching boto3

[michaelbrewer]

What were you trying to accomplish?
I am have my shared code include @tracer but i don't want to double patch boto3 etc..

Expected Behavior

tracer = Tracer(auto_patch=False) should not disable patching in the main lambda handler

Current Behavior

When i go into the console now of the boto3 activity appears

# main.py
from aws_lambda_powertools import Tracer
from app import shared

tracer = Tracer(service="payment")

@tracer.capture_lambda_handler
def handler(event, context):
     pass

# shared.py
from aws_lambda_powertools import Tracer

tracer = Tracer(auto_patch=False)

Possible Solution

I think because the shared.py - tracer = Tracer(auto_patch=False) code is called before the main.py. The patching has already been disabled.

Environment

• Powertools version used: 1.1.1

[heitorlessa]

That’s exactly it Michael - Could you try removing auto_patch from your shared? Under the hood, a module is only patched once by X-Ray SDK as it uses the importlib package. I’ll leave this open to add a clarification note in the docs about this

…

On Sat, 15 Aug 2020 at 05:02, Michael Brewer ***@***.***> wrote: *What were you trying to accomplish?* I am have my shared code include @tracer but i don't want to double patch boto3 etc.. Expected Behavior tracer = Tracer(auto_patch=False) should not disable patching in the main lambda handler Current Behavior When i go into the console now of the boto3 activity appears # main.pyfrom aws_lambda_powertools import Tracerfrom app import shared tracer = Tracer(service="payment") @tracer.capture_lambda_handlerdef handler(event, context): pass # shared.pyfrom aws_lambda_powertools import Tracer tracer = Tracer(auto_patch=False) Possible Solution I think because the shared.py - tracer = Tracer(auto_patch=False) code is called before the main.py. The patching has already been disabled. Environment - *Powertools version used*: 1.1.1 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#108>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZPQBGD7VEEB7EREACBVJLSAX3CZANCNFSM4QABHJ4A> .

[michaelbrewer]

Ok. Then I must have misunderstood the docs. I thought if you don't want to double patch you turn it off in the shared code but it will patch in the main handler file.

Currently I don't include it and it works. I guess it is a matter looking closely at the docs.

[heitorlessa]

Nope, it’s on us - I had a second look at the docs and the wording isn’t right; I‘ll fix it

…

On Sat, 15 Aug 2020 at 06:54, Michael Brewer ***@***.***> wrote: Ok. Then I must have misunderstood the docs. I thought if you don't want to double patch you turn it off in the shared code but it will patch in the main handler file. Currently I don't include it and it works. I guess it is a matter looking closely at the docs. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#108 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZPQBHCQW32UW4MCPZA47LSAYIH7ANCNFSM4QABHJ4A> .

[heitorlessa]

@michaelbrewer When you can, could you please review the docs statement to make sure it's clearer? PR #109